m038
1f4e2aeba5
A ui-test entry had survived into the active trip's dailies. Three independent failures had to line up for that, and all three were real: 1. cleanupEntry() used host-side fs.rmSync. Grav's Apache workers run as root, so every entry the form creates is root-owned and recursive removal needs write permission on that directory — which the host user lacks. Cleanup had never worked for form-created entries; it just threw inside a path nothing checked. It now falls back to `docker exec … rm -rf` in the container that actually serves USER_DIR. 2. globalTeardown's dailies sweep keyed off a `parent:` in post-form.md — a key deliberately removed (the write target comes from site.yaml active_trip, and CLAUDE.md forbids re-adding a static parent). The regex could never match, so dailiesDir was always null and the sweep silently did nothing. It now reuses helpers' own resolution instead of keeping a divergent copy. 3. Nothing pinned the suite to this checkout's server. playwright.config.js defaults to :8081, so a worktree run hit the MAIN checkout — entries created in one content tree while the specs asserted and cleaned up in another. test-ui now passes GRAV_BASE_URL from GRAV_PORT, and globalSetup hard-fails when the server's bind mount disagrees with the tree the specs read. Also fixed, found on the way to a green run: - test-account interpolated the password into an `sh -c` string, so a password containing a shell metacharacter was re-parsed by the container's shell (`sh: 2: <fragment>: not found`, no account, every UI run dead). It now travels via `docker exec -e`, making the recipe indifferent to its contents. - `make start` in a worktree always failed: travel-memories declares `env_file: .env` and worktree-new creates none. It degrades to start-grav there — a worktree with no server is what sent runs to :8081 in the first place. - test-form-config asserted a hero_image field that 8cf1145 deliberately removed; it had been failing ever since. Verified: config 22/22, post 6/6, location-override 20/20, and a full UI run now leaves zero ui-test entries behind. The remaining UI failures are pre-existing on main — site.yaml pins owner_username to a real account while the suite logs in as testrunner, so owner-only controls never render for it. Only trip-publish.spec.js patches that; delete-flow, edit-mode and anon-view do not. Left for a separate branch.
84 lines
3.8 KiB
Bash
Executable File
84 lines
3.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Validates that post-form.md is wired correctly for the add-page-by-form plugin.
|
|
# Fast, no server needed. Catches the class of bug that caused silent post failures.
|
|
set -euo pipefail
|
|
|
|
FORM="user/pages/02.post/post-form.md"
|
|
SITE="user/config/site.yaml"
|
|
PASS=0
|
|
FAIL=0
|
|
ERRORS=()
|
|
|
|
ok() { echo " ✓ $1"; PASS=$((PASS+1)); }
|
|
fail() { echo " ✗ $1"; FAIL=$((FAIL+1)); ERRORS+=("$1"); }
|
|
|
|
check_grep() {
|
|
local desc="$1"; local pattern="$2"; local file="${3:-$FORM}"
|
|
if grep -q "$pattern" "$file"; then ok "$desc"; else fail "$desc"; fi
|
|
}
|
|
|
|
check_absent() {
|
|
local desc="$1"; local pattern="$2"; local file="${3:-$FORM}"
|
|
if grep -q "$pattern" "$file"; then fail "$desc"; else ok "$desc"; fi
|
|
}
|
|
|
|
echo ""
|
|
echo "Form config validator — $FORM"
|
|
echo "────────────────────────────────────────"
|
|
|
|
# Plugin trigger: must use add_page or addpage — NOT add-page-by-form
|
|
grep -q "add_page:\|addpage:" "$FORM" && ok "Process action is 'add_page' (plugin trigger)" \
|
|
|| fail "Process action must be 'add_page: true' — 'add-page-by-form' is not handled by the plugin"
|
|
|
|
# Parent is now injected server-side from site.active_trip by the cache-on-save
|
|
# plugin (U1). The form must NOT hardcode pageconfig.parent — that coupling was
|
|
# the silent-misfile bug this whole change removes.
|
|
check_absent "pageconfig.parent is NOT hardcoded (injected server-side from active_trip)" "^\s*parent:"
|
|
check_grep "pageconfig block exists in frontmatter" "^pageconfig:"
|
|
check_grep "slug_field set (determines entry folder name)" "slug_field:"
|
|
check_grep "pagefrontmatter block exists in frontmatter" "^pagefrontmatter:"
|
|
check_grep "template: entry (creates entry.md filename)" "template: entry"
|
|
|
|
# The active trip — the server-side injection source — must be set in site.yaml.
|
|
check_grep "active_trip set in site.yaml (injection source)" "^active_trip:\s*\S" "$SITE"
|
|
|
|
# Form name must stay 'new-entry' — cache-on-save plugin checks this exact string
|
|
check_grep "form name is 'new-entry' (required by cache-on-save plugin)" "name: new-entry"
|
|
|
|
# Core form fields
|
|
check_grep "title field present" "name: title"
|
|
check_grep "date field present" "name: date"
|
|
check_grep "content field present" "name: content"
|
|
check_grep "photos field present" "name: photos"
|
|
check_grep "lat field present" "name: lat"
|
|
check_grep "lng field present" "name: lng"
|
|
check_grep "location_city field present" "name: location_city"
|
|
check_grep "location_country field present" "name: location_country"
|
|
|
|
# Fields exposed by U2 (weather picker + transport + advanced trio)
|
|
check_grep "weather_desc field present" "name: weather_desc"
|
|
check_grep "weather_temp_c field present" "name: weather_temp_c"
|
|
check_grep "transport_mode field present" "name: transport_mode"
|
|
# No hero_image assertion: the field was deliberately dropped in 8cf1145 —
|
|
# entries render their hero from the first photo, so an explicit filename was
|
|
# redundant (see the comment at that spot in post-form.md). This check outlived
|
|
# the field and had been failing ever since.
|
|
check_grep "force_connect field present" "name: force_connect"
|
|
check_grep "featured field present" "name: featured"
|
|
|
|
# Photos use Grav's filepond field; post-form.js hooks its beforeAddFile to
|
|
# convert HEIC->JPEG before FilePond uploads (U4).
|
|
check_grep "photos field uses the filepond type" "type: filepond"
|
|
|
|
echo "────────────────────────────────────────"
|
|
echo " $PASS passed, $FAIL failed"
|
|
|
|
if [ ${#ERRORS[@]} -gt 0 ]; then
|
|
echo ""
|
|
echo "Failed checks:"
|
|
for e in "${ERRORS[@]}"; do echo " → $e"; done
|
|
echo ""
|
|
exit 1
|
|
fi
|
|
echo ""
|