m038/intotheeast-com
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(review): make the mismatch-blocks-submit test able to fail; carve out the map doctrine

Browse Source 
The U5 guard asserted only `.notices` toHaveCount(0) and toHaveURL(/\/post/).
Both pass instantly, and both also hold for a *successful* submit — the form
posts to /post and only renders its notice after the round trip, and the click
is dispatched via evaluate(el => el.click()), which skips Playwright's
navigation-aware waiting. So the one test standing between a bad coordinate
and the server could not fail. It now proves the negative on disk via
findEntry() after a settling interval, registers the tag for cleanup before
the click, and asserts the flag and value survived.

CLAUDE.md's "one map path" section stated flatly that a single map code path
exists, which location-map.js now contradicts. Recorded it as the one
sanctioned exception (an editor, not a display map; lazy-imported; shares only
MAP_STYLE) rather than leaving the doctrine wrong.

The `user` gitlink is deliberately NOT bumped here: its pin already points at
an unpushed submodule commit, which must be pushed and re-pointed before this
branch merges.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
m038
2026-07-24 21:34:17 +02:00
co-authored by Claude Opus 5
parent a517331d1b
commit 829325c9c7
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+3 -1
View File
@@ -42,7 +42,9 @@ The site is structured around Trip entities. Key facts:
### One map path: `MapUtils.initEntryMap` + the `entry-map` partial
There is a **single** map code path on the site. The engine is `MapUtils.initEntryMap(opts)` in `js/src/maplibre-utils.js` (bundled into `js/map.js` via `make build-assets` — never hand-edit `js/map.js`). It builds the MapLibre map, places markers/popups, fits bounds, draws the GPX journey, and wires the fullscreen toggle.
There is a **single** map code path for every **display** map on the site. The engine is `MapUtils.initEntryMap(opts)` in `js/src/maplibre-utils.js` (bundled into `js/map.js` via `make build-assets` — never hand-edit `js/map.js`). It builds the MapLibre map, places markers/popups, fits bounds, draws the GPX journey, and wires the fullscreen toggle.
**One sanctioned exception — the post form's pin editor.** `js/src/location-map.js` (`getOrCreateLocationMap()`) is a deliberately separate, minimal engine for the `/post` form's "More location details" panel: one *draggable* marker, no popups, no GPX, no bounds-fitting, and `maplibre-gl` **lazy-imported** so a GPS-only submit never fetches it. It is an editor, not a display map, so it shares none of `initEntryMap`'s concerns. The two share exactly one thing — the style URL, extracted into `js/src/map-style.js` (`MAP_STYLE`) and imported by both, so the basemap can never drift between them. Do not fold it into `initEntryMap`, and do not add a *third* path: a new display map uses `initEntryMap` + the `entry-map` partial.
The map **markup + invocation** is shared via one partial: